[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space |
|
Date: |
Tue, 12 Dec 2017 10:20:32 +0000 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 12, 2017 at 01:25:30AM +0000, Liu, Changpeng wrote:
> > The vhost-blk code should also check that
> > hdev->vhost_ops->vhost_set_config != NULL during realize. This way
> > users see the error when adding the device instead of at runtime when
> > the function gets called.
> For vhost-blk, get_config is mandatory, but for set_config, it should depend
> on the feature bit: VIRTIO_BLK_F_CONFIG_WCE is enabled or not. Of course,
> migration should be another case. So running time error process should be
> okay.
Okay.
Stefan
signature.asc
Description: PGP signature