[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v5 19/26] qapi: introduce new cmd option "allow-oo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC v5 19/26] qapi: introduce new cmd option "allow-oob" |
Date: |
Thu, 14 Dec 2017 12:42:34 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 05, 2017 at 01:51:53PM +0800, Peter Xu wrote:
> Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means
> the command allows out-of-band execution.
>
> The "oob" idea is proposed by Markus Armbruster in following thread:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02057.html
>
> This new "allow-oob" boolean will be exposed by "query-qmp-schema" as
> well for command entries, so that QMP clients can know which command can
> be used as out-of-band calls. For example the command "migrate"
> originally looks like:
>
> {"name": "migrate", "ret-type": "17", "meta-type": "command",
> "arg-type": "86"}
>
> And it'll be changed into:
>
> {"name": "migrate", "ret-type": "17", "allow-oob": false,
> "meta-type": "command", "arg-type": "86"}
>
> This patch only provides the QMP interface level changes. It does not
> contains the real out-of-band execution implementation yet.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> include/qapi/qmp/dispatch.h | 1 +
> qapi/introspect.json | 6 +++++-
> scripts/qapi-commands.py | 19 ++++++++++++++-----
> scripts/qapi-introspect.py | 10 ++++++++--
> scripts/qapi.py | 15 ++++++++++-----
> scripts/qapi2texi.py | 2 +-
> tests/qapi-schema/test-qapi.py | 2 +-
> 7 files changed, 40 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [RFC v5 17/26] qmp: add new event "request-dropped", (continued)
[Qemu-devel] [RFC v5 19/26] qapi: introduce new cmd option "allow-oob", Peter Xu, 2017/12/05
[Qemu-devel] [RFC v5 20/26] qmp: support out-of-band (oob) execution, Peter Xu, 2017/12/05
[Qemu-devel] [RFC v5 21/26] qmp: isolate responses into io thread, Peter Xu, 2017/12/05