[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect per tar
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect per target |
|
Date: |
Thu, 14 Dec 2017 17:30:07 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> The following patches are going to introduce per-target #ifdef, and
> but the introspection data is generated only once, and must thus be
> built with the target.
"and but"?
> Drop "do_test_visitor_in_qmp_introspect(&&qmp_schema_qlit)" since it
s/&&/&/
> is no longer in a common object, and covered by "query-qmp-schema
> test" instead.
Do you mean test /x86_64/qmp/query-qmp-schema of tests/qmp-test.c?
That test tests significantly less. It runs the command, tests it
succeeds and returns something. The test you remove additionally tests
the returned value conforms to the schema, by passing it to
visit_type_SchemaInfoList().
Perhaps we can enhance the test you keep to avoid this loss.
> Signed-off-by: Marc-André Lureau <address@hidden>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect per target,
Markus Armbruster <=