[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: change powernv_ prefix to p
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency |
Date: |
Sat, 16 Dec 2017 00:01:15 +1100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Dec 15, 2017 at 08:16:57AM +0100, Cédric Le Goater wrote:
> On 12/15/2017 07:43 AM, Alexey Kardashevskiy wrote:
> > On 15/12/17 17:17, Cédric Le Goater wrote:
> >> Signed-off-by: Cédric Le Goater <address@hidden>
> >> ---
> >> hw/ppc/pnv.c | 84
> >> ++++++++++++++++++++++++++--------------------------
> >> hw/ppc/pnv_core.c | 8 ++---
> >> hw/ppc/pnv_lpc.c | 2 +-
> >> include/hw/ppc/pnv.h | 8 ++---
> >> 4 files changed, 51 insertions(+), 51 deletions(-)
> >>
> >> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> >> index c35c439d816b..4bc5f61d0da7 100644
> >> --- a/hw/ppc/pnv.c
> >> +++ b/hw/ppc/pnv.c
> >> @@ -77,7 +77,7 @@ static const char *pnv_chip_core_typename(const PnvChip
> >> *o)
> >> * that has a different "affinity". In practice, it means one range
> >> * per chip.
> >> */
> >> -static void powernv_populate_memory_node(void *fdt, int chip_id, hwaddr
> >> start,
> >> +static void pnv_populate_memory_node(void *fdt, int chip_id, hwaddr start,
> >> hwaddr size)
> >
> > You may also want to fix indentations like the line above.
>
> yes. I missed that. I should run indent after using sed.
>
> While I am at it, I can also change the name of the routines
> populating the device tree.
>
> David,
>
> are you following more or less this pattern :
>
> <machine>_dt_<device>
Well, I'd only really thought about it for pseries, and I'm using
"spapr_dt_whatever()" there rather than "pseries_dt_whatever()". Plus
that's where I'm intending to head, but I think there are still a fair
few exceptions.
"pnv_dt_whatever()" seems like a good convention for the powernv code,
though.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature