[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3 07/13] eepro100: use inline net_crc32() and bitshi
From: |
Mark Cave-Ayland |
Subject: |
[Qemu-devel] [PATCHv3 07/13] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx() |
Date: |
Fri, 15 Dec 2017 18:41:49 +0000 |
This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.
Signed-off-by: Mark Cave-Ayland <address@hidden>
---
hw/net/eepro100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
index e30fed830b..a07a63247e 100644
--- a/hw/net/eepro100.c
+++ b/hw/net/eepro100.c
@@ -1679,7 +1679,7 @@ static ssize_t nic_receive(NetClientState *nc, const
uint8_t * buf, size_t size)
rfd_status |= 0x0004;
} else if (s->configuration[20] & BIT(6)) {
/* Multiple IA bit set. */
- unsigned mcast_idx = compute_mcast_idx(buf);
+ unsigned mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
assert(mcast_idx < 64);
if (s->mult[mcast_idx >> 3] & (1 << (mcast_idx & 7))) {
TRACE(RXTX, logout("%p accepted, multiple IA bit set\n", s));
--
2.11.0
- [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 06/13] sungem: fix multicast filter CRC calculation, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 02/13] net: introduce net_crc32_le() function, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 01/13] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 09/13] lan9118: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 08/13] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 07/13] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx(),
Mark Cave-Ayland <=
- [Qemu-devel] [PATCHv3 03/13] pcnet: switch pcnet over to use net_crc32_le(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 04/13] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 05/13] sunhme: switch sunhme over to use net_crc32_le(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 12/13] rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 10/13] ftgmac100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 13/13] net: remove unused compute_mcast_idx() function, Mark Cave-Ayland, 2017/12/15
- [Qemu-devel] [PATCHv3 11/13] ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Mark Cave-Ayland, 2017/12/15
- Re: [Qemu-devel] [PATCHv3 00/13] net: introduce common net_crc32() and net_crc32_le() functions, Jason Wang, 2017/12/20