[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] sdhci: some ARM boards do support SD_HOST_S
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] sdhci: some ARM boards do support SD_HOST_SPECv3_VERS |
Date: |
Fri, 15 Dec 2017 16:00:52 -0800 |
On Wed, Dec 13, 2017 at 6:00 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> set the property with object_property_set_uint() or qdev_prop_set_uint8().
>
> [Zynq part based on a patch from Alistair Francis <address@hidden>
> from qemu/xilinx tag xilinx-v2015.2]
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/arm/bcm2835_peripherals.c | 7 +++++++
> hw/arm/fsl-imx6.c | 6 ++++++
> hw/arm/xilinx_zynq.c | 2 ++
> 3 files changed, 15 insertions(+)
>
> diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
> index 60a0eec4d1..e686725015 100644
> --- a/hw/arm/bcm2835_peripherals.c
> +++ b/hw/arm/bcm2835_peripherals.c
> @@ -264,6 +264,13 @@ static void bcm2835_peripherals_realize(DeviceState
> *dev, Error **errp)
> return;
> }
>
> + object_property_set_uint(OBJECT(&s->sdhci), SD_HOST_SPECv3_VERS,
> + "sd-spec-version", &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> +
> object_property_set_bool(OBJECT(&s->sdhci), true, "realized", &err);
> if (err) {
> error_propagate(errp, err);
> diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
> index 59ef33efa9..c474e707af 100644
> --- a/hw/arm/fsl-imx6.c
> +++ b/hw/arm/fsl-imx6.c
> @@ -348,6 +348,12 @@ static void fsl_imx6_realize(DeviceState *dev, Error
> **errp)
> { FSL_IMX6_uSDHC4_ADDR, FSL_IMX6_uSDHC4_IRQ },
> };
>
> + object_property_set_uint(OBJECT(&s->esdhc[i]), SD_HOST_SPECv3_VERS,
> + "sd-spec-version", &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
> + }
> object_property_set_bool(OBJECT(&s->esdhc[i]), true, "realized",
> &err);
> if (err) {
> error_propagate(errp, err);
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index 9275ae6daf..0292feea74 100644
> --- a/hw/arm/xilinx_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -250,6 +250,7 @@ static void zynq_init(MachineState *machine)
>
> dev = qdev_create(NULL, TYPE_SYSBUS_SDHCI);
> qdev_prop_set_string(dev, "sd-bus-name", "sd.0");
> + qdev_prop_set_uint8(dev, "sd-spec-version", SD_HOST_SPECv3_VERS);
> qdev_init_nofail(dev);
> sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0xE0100000);
> sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic[56-IRQ_OFFSET]);
> @@ -262,6 +263,7 @@ static void zynq_init(MachineState *machine)
> object_property_set_bool(OBJECT(carddev), true, "realized",
> &error_fatal);
>
> dev = qdev_create(NULL, TYPE_SYSBUS_SDHCI);
> + qdev_prop_set_uint8(dev, "sd-spec-version", SD_HOST_SPECv3_VERS);
> qdev_prop_set_string(dev, "sd-bus-name", "sd.1");
> qdev_init_nofail(dev);
> sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0xE0101000);
> --
> 2.15.1
>
>
- [Qemu-devel] [PATCH 0/8] SDHCI: add a qtest and fix few issues, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [PATCH 1/8] sdhci: add a "sd-spec-version" property, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [PATCH 2/8] sdhci: some ARM boards do support SD_HOST_SPECv3_VERS, Philippe Mathieu-Daudé, 2017/12/13
- Re: [Qemu-devel] [PATCH 2/8] sdhci: some ARM boards do support SD_HOST_SPECv3_VERS,
Alistair Francis <=
- [Qemu-devel] [PATCH 3/8] sdhci: add qtest to check the SD Spec version, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [PATCH 4/8] sdhci: fix CAPAB/MAXCURR registers, both are 64bit and read-only, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [PATCH 5/8] sdhci: add check_capab_readonly() qtest, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [RFC PATCH 7/8] sdhci: add a check_capab_sdma() qtest, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [PATCH 6/8] sdhci: add a check_capab_baseclock() qtest, Philippe Mathieu-Daudé, 2017/12/13
- [Qemu-devel] [PATCH 8/8] sdhci: add a check_capab_v3() qtest, Philippe Mathieu-Daudé, 2017/12/13