[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle |
Date: |
Mon, 18 Dec 2017 14:27:15 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Dec 13, 2017 at 07:59:49PM -0500, John Snow wrote:
> +/**
> + * block_job_throttle:
> + * @job: The job that calls the function.
> + *
> + * Yield if it has been SLICE_TIME nanoseconds since the last yield.
> + * Otherwise, check if we need to pause (and update the yield counter).
> + */
> +void block_job_throttle(BlockJob *job);
This name is easily confused with the block-job-set-speed
ratelimit/throttling feature.
I suggest block_job_cpu_relax() or just block_job_relax() to make it
clear we're giving up our CPU time voluntarily - but this isn't
"throttling".
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 1/7] blockjob: record time of last yield, (continued)
- [Qemu-devel] [PATCH 2/7] blockjob: consolidate SLICE_TIME definition, John Snow, 2017/12/13
- [Qemu-devel] [PATCH 3/7] blockjob: create block_job_throttle, John Snow, 2017/12/13
- [Qemu-devel] [PATCH 6/7] block/stream: use block_job_throttle, John Snow, 2017/12/13
- [Qemu-devel] [PATCH 7/7] block/backup: use block_job_throttle, John Snow, 2017/12/13
- [Qemu-devel] [PATCH 5/7] block/commit: use block_job_throttle, John Snow, 2017/12/13
- [Qemu-devel] [PATCH 4/7] blockjob: allow block_job_throttle to take delay_ns, John Snow, 2017/12/13