[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a varia
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/13] build-sys: add a rule to print a variable |
Date: |
Tue, 19 Dec 2017 16:45:48 +0100 |
Hi
On Fri, Dec 15, 2017 at 7:28 PM, Eric Blake <address@hidden> wrote:
> On 12/15/2017 09:06 AM, Marc-André Lureau wrote:
>> $ make print-CFLAGS
>> CFLAGS=-fsanitize=address -Og -g
>>
>> Trick from various sources:
>> https://stackoverflow.com/questions/16467718/how-to-print-out-a-variable-in-makefile
>> https://www.cmcrossroads.com/article/printing-value-makefile-variable
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>> Makefile | 5 ++++-
>> docs/devel/build-system.txt | 13 +++++++++++++
>> 2 files changed, 17 insertions(+), 1 deletion(-)
>
>> +++ b/docs/devel/build-system.txt
>> @@ -510,3 +510,16 @@ default-configs/$TARGET-NAME file as input.
>> This is the entrypoint used when make recurses to build a single system
>> or userspace emulator target. It is merely a symlink back to the
>> Makefile.target in the top level.
>> +
>> +
>> +Useful make targets
>> +===================
>> +
>> +- help
>> +
>> + Print a help message for the most common build targets.
>
> Except that this patch forgot to tweak 'make help' to mention 'make
> print-VAR' ;)
Well, I don't think print-VAR is a common build target, it's a
build-sys hack/debug imho, so having it described in build-system.txt
only make sense.
Do you agree?
thanks
--
Marc-André Lureau
- [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 06/13] vl: fix direct firmware directories leak, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 05/13] tests: fix check-qobject leak:, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 09/13] crypto: fix stack-buffer-overflow error, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 07/13] readline: add a free function, Marc-André Lureau, 2017/12/15