Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

[Marcel Apfelbaum]

On 19/12/2017 18:12, Michael S. Tsirkin wrote:
> On Sun, Dec 17, 2017 at 02:54:56PM +0200, Marcel Apfelbaum wrote:
> > @@ -2847,15 +2847,16 @@ if test "$rdma" != "no" ; then
> >   #include <rdma/rdma_cma.h>
> >   int main(void) { return 0; }
> >   EOF
> > -  rdma_libs="-lrdmacm -libverbs"
> > +  rdma_libs="-lrdmacm -libverbs -libumad"
> >     if compile_prog "" "$rdma_libs" ; then
> >       rdma="yes"
> >     else
> > +    libs_softmmu="$libs_softmmu $rdma_libs"
> >       if test "$rdma" = "yes" ; then
> >           error_exit \
> > -            " OpenFabrics librdmacm/libibverbs not present." \
> > +            " OpenFabrics librdmacm/libibverbs/libibumad not present." \
> >               " Your options:" \
> > -            "  (1) Fast: Install infiniband packages from your distro." \
> > +           "  (1) Fast: Install infiniband packages (devel) from your distro." 
> > \
> >               "  (2) Cleanest: Install libraries from www.openfabrics.org" \
> >               "  (3) Also: Install softiwarp if you don't have RDMA hardware"
> >       fi
>
> Some whitespace damage here.

Thanks Michael, we will take care of that and go over
the code again to spot similar issues.

Marcel