[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement

From: Matthew Wilcox
Subject: Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement
Date: Wed, 20 Dec 2017 04:25:47 -0800
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, Dec 20, 2017 at 06:34:36PM +0800, Wei Wang wrote:
> On 12/19/2017 10:05 PM, Tetsuo Handa wrote:
> > I think xb_find_set() has a bug in !node path.
> I think we can probably remove the "!node" path for now. It would be good to
> get the fundamental part in first, and leave optimization to come as
> separate patches with corresponding test cases in the future.

You can't remove the !node path.  You'll see !node when the highest set
bit is less than 1024.  So do something like this:

        unsigned long bit;
        xb_set_bit(xb, 700);
        bit = xb_find_set(xb, ULONG_MAX, 0);
        assert(bit == 700);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]