[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue f
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full |
Date: |
Thu, 21 Dec 2017 19:42:46 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, 12/19 16:45, Peter Xu wrote:
> Set maximum QMP command queue length to 8. If queue full, instead of
> queue the command, we directly return a "command-dropped" event, telling
> client that specific command is dropped.
>
> Note that this flow control mechanism is only valid if OOB is enabled.
> If it's not, the effective queue length will always be 1, which strictly
> follows original behavior of QMP command handling (which never drop
> messages).
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> monitor.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index ed9a741d06..b571866659 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4038,6 +4038,8 @@ static void monitor_qmp_bh_dispatcher(void *data)
> }
> }
>
> +#define QMP_REQ_QUEUE_LEN_MAX (8)
Is this limit introspectable on QMP?
Fam
- [Qemu-devel] [RFC v6 14/27] monitor: let suspend_cnt be thread safe, (continued)
- [Qemu-devel] [RFC v6 14/27] monitor: let suspend_cnt be thread safe, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 15/27] monitor: let suspend/resume work even with QMPs, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 16/27] monitor: separate QMP parser and dispatcher, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 17/27] qmp: add new event "command-dropped", Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, Peter Xu, 2017/12/19
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full,
Fam Zheng <=
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, Peter Xu, 2017/12/25
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, Fam Zheng, 2017/12/25
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, Peter Xu, 2017/12/25
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, Fam Zheng, 2017/12/25
- Re: [Qemu-devel] [RFC v6 18/27] monitor: send event when command queue full, Peter Xu, 2017/12/25
[Qemu-devel] [RFC v6 19/27] qapi: introduce new cmd option "allow-oob", Peter Xu, 2017/12/19
[Qemu-devel] [RFC v6 20/27] qmp: export qmp_dispatch_check_obj and allow "id", Peter Xu, 2017/12/19
[Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution, Peter Xu, 2017/12/19