[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/7] vhost: Regenerate region list from chang
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/7] vhost: Regenerate region list from changed sections list |
Date: |
Thu, 28 Dec 2017 14:03:23 +0100 |
On Wed, 27 Dec 2017 14:19:03 +0100
Igor Mammedov <address@hidden> wrote:
> On Mon, 18 Dec 2017 20:13:38 +0000
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
>
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Compare the sections list that's just been generated, and if it's
> > different from the old one regenerate the region list.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
[...]
>
> > + if (!dev->started) {
> also why memmap is generated this early and not right before first use?
> here we might generate memap but not actually use it.
I retract question, as commit + follow up set_mem_table could happen before
device is started. Having a comment here explaining it would be nice as
the call flow is obvious.
> > goto out;
> > }
> >
>
>
- [Qemu-devel] [PATCH v5 2/7] vhost: Move log_dirty check, (continued)
- [Qemu-devel] [PATCH v5 2/7] vhost: Move log_dirty check, Dr. David Alan Gilbert (git), 2017/12/18
- [Qemu-devel] [PATCH v5 1/7] vhost: Build temporary section list and deref after commit, Dr. David Alan Gilbert (git), 2017/12/18
- [Qemu-devel] [PATCH v5 3/7] vhost: Simplify ring verification checks, Dr. David Alan Gilbert (git), 2017/12/18
- [Qemu-devel] [PATCH v5 4/7] vhost: Merge sections added to temporary list, Dr. David Alan Gilbert (git), 2017/12/18
- [Qemu-devel] [PATCH v5 5/7] vhost: Regenerate region list from changed sections list, Dr. David Alan Gilbert (git), 2017/12/18
- [Qemu-devel] [PATCH v5 7/7] vhost: Merge and delete unused callbacks, Dr. David Alan Gilbert (git), 2017/12/18
- [Qemu-devel] [PATCH v5 6/7] vhost: Clean out old vhost_set_memory and friends, Dr. David Alan Gilbert (git), 2017/12/18
- Re: [Qemu-devel] [PATCH v5 0/7] Rework vhost memory region updates, Igor Mammedov, 2017/12/27