[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error |
Date: |
Thu, 4 Jan 2018 10:18:45 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Jan 03, 2018 at 01:31:01PM +0100, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > It should be called in migrate_fd_cleanup too.
>
> It is *already* called in migrate_fd_cleanup.
>
> I think we should add a comment stating that we _always_ end calling
> migrate_fd_cleanup, independently of how the migration ends.
>
>
> > Signed-off-by: Peter Xu <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> I can also fix the comment when pulling if you agree with the change.
Yes. Please modify according to your suggestions (including the other
patch comment). Thanks for that!
--
Peter Xu
- [Qemu-devel] [PATCH v2 08/13] migration: use switch at the end of migration, (continued)
- [Qemu-devel] [PATCH v2 08/13] migration: use switch at the end of migration, Peter Xu, 2018/01/03
- [Qemu-devel] [PATCH v2 09/13] migration: cleanup stats update into function, Peter Xu, 2018/01/03
- [Qemu-devel] [PATCH v2 10/13] migration: major cleanup for migrate iterations, Peter Xu, 2018/01/03
- [Qemu-devel] [PATCH v2 11/13] migration: put the finish part into a new function, Peter Xu, 2018/01/03
- [Qemu-devel] [PATCH v2 12/13] migration: remove some block_cleanup_parameters(), Peter Xu, 2018/01/03
- [Qemu-devel] [PATCH v2 13/13] migration: remove notify in fd_error, Peter Xu, 2018/01/03