[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1 |
Date: |
Fri, 5 Jan 2018 20:25:01 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, 01/05 11:49, Alex Bennée wrote:
>
> Fam Zheng <address@hidden> writes:
>
> > On Wed, 01/03 15:54, Michael Clark wrote:
> >> On Wed, Jan 3, 2018 at 3:41 PM, Fam Zheng <address@hidden> wrote:
> >>
> >> > On Wed, 01/03 15:00, Michael Clark wrote:
> >> > > So it's essentially one error, the single line case pattern for
> >> > > table-driven decode which flags for long lines and asks to separate
> >> > > break
> >> > > onto its own line.
> <snip>
> >> > Thanks for taking a look! Practically, consistency with the rest of the
> >> > code and
> >> > human judgements (comments, explanation in replies etc.) often override
> >> > the
> >> > checkpatch complaints. Checkpatch is not always right.
> <snip>
>
> Fam,
>
> I wonder is there anyway we could signal to patchew that there are some
> acknowledged and approved coding style variances in the patch? Would
> something like:
>
> CodingStyleExceptions: 12
>
> Be too polluting to the commit messages? Or perhaps something that can
> skip individual tests on a given run:
>
> CheckpatchFlags: --ignore-long-lines
It sounds feasible. Putting these flags after a --- line will keep commit
message clean.
OTOH I think we should spend effort on patching checkpatch.pl to implement this.
Fam
- Re: [Qemu-devel] [PATCH v1 21/21] RISC-V Build Infrastructure, (continued)
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, no-reply, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Michael Clark, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Michael Clark, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Fam Zheng, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Michael Clark, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Fam Zheng, 2018/01/02
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Alex Bennée, 2018/01/05
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Alex Bennée, 2018/01/05
- Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Paolo Bonzini, 2018/01/05
Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Richard W.M. Jones, 2018/01/03
Re: [Qemu-devel] [PATCH v1 00/21] RISC-V QEMU Port Submission v1, Christoph Hellwig, 2018/01/08