[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/1] input-linux: provide hotkeys for evdev togg
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/1] input-linux: provide hotkeys for evdev toggle |
Date: |
Sun, 7 Jan 2018 03:31:06 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/1] input-linux: provide hotkeys for evdev toggle
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8d2dfcbd73 input-linux: provide hotkeys for evdev toggle
=== OUTPUT BEGIN ===
Checking PATCH 1/1: input-linux: provide hotkeys for evdev toggle...
ERROR: consider using qemu_strtol in preference to strtol
#77: FILE: vl.c:3384:
+ qemu_evdev_rhotkey = strtol(optarg, NULL, 0);
ERROR: consider using qemu_strtol in preference to strtol
#80: FILE: vl.c:3387:
+ qemu_evdev_lhotkey = strtol(optarg, NULL, 0);
ERROR: Missing Signed-off-by: line(s)
total: 3 errors, 0 warnings, 56 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden