[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments |
Date: |
Wed, 10 Jan 2018 14:25:45 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote:
> Argument file is also needed there.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Does it also mean this?
Fixes: aaf89c8a49a8c ("test: port postcopy test to ppc64")
> ---
> tests/migration-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 0448bc77dc..32f3bb86a8 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -464,8 +464,9 @@ static void test_migrate_start(QTestState **from,
> QTestState **to,
> cmd_dst = g_strdup_printf("-machine accel=%s -m 256M"
> " -name pcdest,debug-threads=on"
> " -serial file:%s/dest_serial"
> + " -drive file=%s,if=pflash,format=raw"
> " -incoming %s",
> - accel, tmpfs, uri);
> + accel, tmpfs, bootpath, uri);
> } else {
> g_assert_not_reached();
> }
> --
> 2.14.3
>
--
Peter Xu
- [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration, Juan Quintela, 2018/01/05
- [Qemu-devel] [PATCH v4 01/11] tests: Remove deprecated migration tests commands, Juan Quintela, 2018/01/05
- [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, Juan Quintela, 2018/01/05
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments,
Peter Xu <=
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, Juan Quintela, 2018/01/10
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, Laurent Vivier, 2018/01/10
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, Laurent Vivier, 2018/01/10
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, Juan Quintela, 2018/01/10
- Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments, Laurent Vivier, 2018/01/10
[Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration, Juan Quintela, 2018/01/05
[Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration, Juan Quintela, 2018/01/05