[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState
Date: Thu, 11 Jan 2018 14:24:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 11/01/2018 11:20, Peter Maydell wrote:
> On 11 January 2018 at 10:15, Paolo Bonzini <address@hidden> wrote:
>> RAM contents are memcpy'd blindly during loadvm.  I think that's what
>> requires a tb_flush.
> Ah, that makes sense. Could we have a comment documenting the
> rationale, please? Something like:
> /* vmload has just updated the content of RAM, bypassing the
>  * usual mechanisms that ensure we flush TBs for writes to
>  * memory we've translated code from. So we must flush all TBs,
>  * which will now be stale.
>  */
> thanks
> -- PMM

Sure, will add it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]