Re: [Qemu-devel] [PATCH v3 04/21] RISC-V Disassembler

[Richard Henderson]

On 01/10/2018 06:21 PM, Michael Clark wrote:
> The RISC-V disassembler has no dependencies outside of the 'disas'
> directory so it can be applied independently. The majority of the
> disassembler is machine-generated from instruction set metadata:
> 
> - https://github.com/michaeljclark/riscv-meta
> 
> Expected checkpatch errors for consistency and brevity reasons:
> 
> ERROR: line over 90 characters
> ERROR: trailing statements should be on next line
> ERROR: space prohibited between function name and open parenthesis '('
> Signed-off-by: Michael Clark <address@hidden>
> ---
>  disas.c             |    2 +
>  disas/Makefile.objs |    1 +
>  disas/riscv.c       | 3054 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/disas/bfd.h |    2 +
>  4 files changed, 3059 insertions(+)
>  create mode 100644 disas/riscv.c

Reviewed-by: Richard Henderson <address@hidden>


r~