Re: [Qemu-devel] [qemu-s390x] [PATCH v3 5/8] s390-ccw: interactive boot menu for eckd dasd (read stage2 data)

[Thomas Huth]

On 17.01.2018 09:38, Thomas Huth wrote:
> On 15.01.2018 17:44, Collin L. Walling wrote:
[...]
>> +        if (find_zipl_boot_menu_banner(&offset)) {
>> +            /* Load the adjacent blocks to account for the
>> +             * possibility of menu data spanning multiple blocks.
>> +             */
>> +            if (prev_block_nr) {
> 
> You did not pre-initialize prev_block_nr = 0 at the beginning of the
> function. Do you feel confident enough that the first block never
> contains the zipl banner? If not, please set prev_block_nr = 0 before
> entering the for-loop.

Ah, I just noticed that this is also the issue that has been reported by
patchew. So you've got to set prev_block_nr = 0 anyway to keep all
compilers happy ;-)

 Thomas