Re: [Qemu-devel] [PATCH v2 0/4] linux-user: select CPU type according ELF header values

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/4] linux-user: select CPU type according ELF 
header values

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   aae39d24a3..c1d5b9add7  master     -> master
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a63a09bfe5 linux-user: MIPS set cpu to r6 CPU if binary is R6
24f37601e2 linux-user, m68k: select CPU according to ELF header values
5e73ad86f5 linux-user: introduce functions to detect CPU type
2eef204e3d linux-user: Move CPU type name selection to a function

=== OUTPUT BEGIN ===
Checking PATCH 1/4: linux-user: Move CPU type name selection to a function...
Checking PATCH 2/4: linux-user: introduce functions to detect CPU type...
Checking PATCH 3/4: linux-user, m68k: select CPU according to ELF header 
values...
Checking PATCH 4/4: linux-user: MIPS set cpu to r6 CPU if binary is R6...
ERROR: suspect code indent for conditional statements (5, 9)
#36: FILE: linux-user/mips/target_elf.h:12:
+     if ((eflags & EF_MIPS_ARCH_32R6) != 0) {
+         return "mips32r6-generic";

ERROR: suspect code indent for conditional statements (5, 9)
#50: FILE: linux-user/mips64/target_elf.h:12:
+     if ((eflags & EF_MIPS_ARCH_64R6) != 0) {
+         return "I6400";

total: 2 errors, 0 warnings, 28 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden