[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free |
Date: |
Fri, 19 Jan 2018 13:16:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 19.01.2018 12:44, Laurent Vivier wrote:
> t64 is also unconditionally freed after the switch () { ... }
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> target/m68k/translate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index f0e86a73d4..ea18df940a 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -969,7 +969,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv
> addr, TCGv_ptr fp)
> case OS_DOUBLE:
> tcg_gen_qemu_ld64(t64, addr, index);
> gen_helper_extf64(cpu_env, fp, t64);
> - tcg_temp_free_i64(t64);
> break;
> case OS_EXTENDED:
> if (m68k_feature(s->env, M68K_FEATURE_CF_FPU)) {
>
Reviewed-by: Thomas Huth <address@hidden>