[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats |
Date: |
Mon, 22 Jan 2018 14:47:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/19/2018 06:50 AM, Anton Nefedov wrote:
> Signed-off-by: Anton Nefedov <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> ---
> qapi/block-core.json | 29 +++++++++++++++++++++++------
> include/block/accounting.h | 1 +
> block/qapi.c | 6 ++++++
> 3 files changed, 30 insertions(+), 6 deletions(-)
>
> @@ -688,6 +693,9 @@
> #
> # @rd_total_time_ns: Total_time_spend on reads in nano-seconds (since
> 0.15.0).
While we are here, we could change s/Total_time_spend/Total time spent/
> #
> +# @unmap_total_time_ns: Total time spent on unmap operations in nano-seconds
> +# (Since 2.12)
Also, s/nano-seconds/nanoseconds/ (for both lines, if we are touching both).
The QAPI maintainer can touch that up (that may be me, depending on
Markus' schedule in the next few weeks); but I'm not seeing any UI
problems with the addition, so
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/8] discard blockstats, Anton Nefedov, 2018/01/19
- [Qemu-devel] [PATCH v2 1/8] qapi: group BlockDeviceStats fields, Anton Nefedov, 2018/01/19
- [Qemu-devel] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats, Anton Nefedov, 2018/01/19
- Re: [Qemu-devel] [PATCH v2 2/8] qapi: add unmap to BlockDeviceStats,
Eric Blake <=
- [Qemu-devel] [PATCH v2 4/8] scsi: store unmap offset and nb_sectors in request struct, Anton Nefedov, 2018/01/19
- [Qemu-devel] [PATCH v2 3/8] ide: account UNMAP (TRIM) operations, Anton Nefedov, 2018/01/19
- [Qemu-devel] [PATCH v2 5/8] scsi: move unmap error checking to the complete callback, Anton Nefedov, 2018/01/19
- [Qemu-devel] [PATCH v2 6/8] scsi: account unmap operations, Anton Nefedov, 2018/01/19
- [Qemu-devel] [PATCH v2 8/8] qapi: query-blockstat: add driver specific file-posix stats, Anton Nefedov, 2018/01/19