[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: implement renameat2
From: |
Andreas Schwab |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: implement renameat2 |
Date: |
Tue, 23 Jan 2018 11:22:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) |
On Jan 23 2018, Laurent Vivier <address@hidden> wrote:
> Please fix style problem reported by patchew
> (or ./scripts/checkpatch.pl)
This was mostly copy-pasted from surrounding code. :-)
>> @@ -8342,6 +8359,22 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
>> arg1,
>> }
>> break;
>> #endif
>> +#if defined(TARGET_NR_renameat2)
>> + case TARGET_NR_renameat2:
>> + {
>> + void *p2;
>> + p = lock_user_string(arg2);
>> + p2 = lock_user_string(arg4);
>> + if (!p || !p2)
>> + ret = -TARGET_EFAULT;
>> + else
>> + ret = get_errno(sys_renameat2(arg1, p, arg3, p2,
>> + target_to_host_bitmask(arg5,
>> fcntl_flags_tbl)));
>
> You can't use fcntl_flags_tbl
Of course! I was confused by another patch I was working on which does
need such a conversion. :-/
Andreas.
--
Andreas Schwab, SUSE Labs, address@hidden
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."