[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3
Date: Tue, 23 Jan 2018 18:14:06 +0000

On 23 January 2018 at 11:49, bzt bzt <address@hidden> wrote:
> Hi,
> On Mon, Jan 22, 2018 at 1:12 PM, Peter Maydell <address@hidden>
> wrote:
>> Can you send this as a proper patch email, not as a reply to
>> an existing email thread, please? (This makes our automated tooling
>> much happier.)
> Only if you're not demanding any further nonsense modifications.

I think that patch review will be much more pleasant for
both of us if you tone down the combativeness here.
Yes, sometimes code review comments aren't right because
the reviewer has missed or misunderstood a detail -- but
there's no need to throw insults around as a result.

If you don't have the time or don't want to engage with the
community's review processes, that's fine. But this hostility
is not pleasant to interact with and off-putting to other
people reading it. Please stop it.

(Sometimes a submitter doesn't have the time to work with our
review process, and that's fine. It just means that the patches
will sit on the mailing list and perhaps in future somebody
who does have the time as well as the interest in the feature
will come along and pick up the work.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]