[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] kvm-all: Partially reverts 4fe6d78b2e to rem
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] kvm-all: Partially reverts 4fe6d78b2e to remove the cleanup call |
Date: |
Wed, 24 Jan 2018 10:40:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 23/01/2018 18:54, Jose Ricardo Ziviani wrote:
> This commit partially reverts the commit 4fe6d78b2e because of issues
> reported in the virtio.
>
> Examples:
>
> $ qemu-system-ppc64 -cpu POWER8 -nographic -vga none -m 4G \
> -M pseries,accel=kvm -netdev type=user,id=net0 \
> -device virtio-net-pci,netdev=net0 -drive file=../disk.qcow2,if=virtio
>
> Populating /vdevice/address@hidden
> Populating /vdevice/address@hidden
> SCSI: Looking for devices
> 8200000000000000 CD-ROM : "QEMU QEMU CD-ROM 2.5+"
> Populating /address@hidden
> 00 0000 (D) : 1af4 1000 virtio [ net ]
> Aborted
>
> $ qemu-system-x86_64 -m 4G -enable-kvm -drive file=util.qcow2,if=virtio
>
> Running QEMU with GTK 2.x is deprecated, and will be removed
> in a future release. Please switch to GTK 3.x instead
> [1] 5282 abort
>
> Reference
> http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg05457.html
>
> Reported-by: Anton Blanchard <address@hidden>
> Signed-off-by: Jose Ricardo Ziviani <address@hidden>
> ---
> accel/kvm/kvm-all.c | 4 ----
> 1 file changed, 4 deletions(-)
Michael, please send a revert for all three of Gal's patches.
Thanks,
Paolo
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 071f4f57c0..f290f487a5 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -812,10 +812,6 @@ static void kvm_mem_ioeventfd_del(MemoryListener
> *listener,
> if (r < 0) {
> abort();
> }
> -
> - if (e->cleanup) {
> - e->cleanup(e);
> - }
> }
>
> static void kvm_io_ioeventfd_add(MemoryListener *listener,
>