[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/8] hmp: Add name parameter to nbd_server_add
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 2/8] hmp: Add name parameter to nbd_server_add |
Date: |
Fri, 26 Jan 2018 10:04:05 -0600 |
Extend the flexibility of the previous QMP patch to also work
in HMP.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
---
hmp.c | 3 ++-
hmp-commands.hx | 9 +++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/hmp.c b/hmp.c
index 5bcfc36de10..7a64dd59c5c 100644
--- a/hmp.c
+++ b/hmp.c
@@ -2221,10 +2221,11 @@ exit:
void hmp_nbd_server_add(Monitor *mon, const QDict *qdict)
{
const char *device = qdict_get_str(qdict, "device");
+ const char *name = qdict_get_try_str(qdict, "name");
bool writable = qdict_get_try_bool(qdict, "writable", false);
Error *local_err = NULL;
- qmp_nbd_server_add(device, false, NULL, true, writable, &local_err);
+ qmp_nbd_server_add(device, !!name, name, true, writable, &local_err);
if (local_err != NULL) {
hmp_handle_error(mon, &local_err);
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 6d5ebdf6ab1..b8b6fb91848 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1553,17 +1553,18 @@ ETEXI
{
.name = "nbd_server_add",
- .args_type = "writable:-w,device:B",
- .params = "nbd_server_add [-w] device",
+ .args_type = "writable:-w,device:B,name:s?",
+ .params = "nbd_server_add [-w] device [name]",
.help = "export a block device via NBD",
.cmd = hmp_nbd_server_add,
},
STEXI
address@hidden nbd_server_add @var{device}
address@hidden nbd_server_add @var{device} [ @var{name} ]
@findex nbd_server_add
Export a block device through QEMU's NBD server, which must be started
beforehand with @command{nbd_server_start}. The @option{-w} option makes the
-exported device writable too.
+exported device writable too. The export name is controlled by @var{name},
+defaulting to @var{device}.
ETEXI
{
--
2.14.3
- [Qemu-devel] [PULL 0/8] NBD patches through 26 Jan, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 1/8] qapi: add name parameter to nbd-server-add, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 3/8] qapi: add nbd-server-remove, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 7/8] hmp: Add nbd_server_remove to mirror QMP command, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 6/8] iotest 205: new test for qmp nbd-server-remove, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 2/8] hmp: Add name parameter to nbd_server_add,
Eric Blake <=
- [Qemu-devel] [PULL 5/8] iotests: implement QemuIoInteractive class, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 4/8] iotest 147: add cases to test new @name parameter of nbd-server-add, Eric Blake, 2018/01/26
- [Qemu-devel] [PULL 8/8] nbd: implement bdrv_get_info callback, Eric Blake, 2018/01/26
- Re: [Qemu-devel] [PULL 0/8] NBD patches through 26 Jan, Peter Maydell, 2018/01/29