[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where ne
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where needed |
Date: |
Tue, 30 Jan 2018 11:51:14 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/30/2018 04:21 AM, Markus Armbruster wrote:
> This cleanup makes the number of objects depending on qapi/qmp/qdict.h
> drop from 4547 (out of 4739) to 368 in my "build everything" tree.
> For qapi/qmp/qobject.h, the number drops from 4549 to 390.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> +++ b/block/qcow.c
> @@ -21,6 +21,7 @@
> * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> * THE SOFTWARE.
> */
> +
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "qemu-common.h"
> @@ -30,6 +31,7 @@
> #include "qemu/module.h"
> #include "qemu/bswap.h"
> #include <zlib.h>
> +#include "qapi/qmp/qdict.h"
Same comments as on other patches in the series.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h, (continued)
- [Qemu-devel] [PATCH 16/18] Drop superfluous includes of qapi/qmp/dispatch.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 15/18] Include qapi/qmp/qnull.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 14/18] Include qapi/qmp/qnum.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 04/18] Drop superfluous includes of qapi/qmp/qerror.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where needed, Markus Armbruster, 2018/01/30
- Re: [Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where needed,
Eric Blake <=
- [Qemu-devel] [PATCH 09/18] Include qapi/qmp/qobject.h exactly where needed, Markus Armbruster, 2018/01/30
- Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time, Philippe Mathieu-Daudé, 2018/01/30
- Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time, no-reply, 2018/01/30
- Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time, no-reply, 2018/01/30
- Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time, Thomas Huth, 2018/01/31