[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h |
Date: |
Wed, 31 Jan 2018 08:49:07 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 01/30/2018 04:21 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>
>> +++ b/tests/test-clone-visitor.c
>> @@ -11,7 +11,6 @@
>>
>> #include "qemu-common.h"
>> #include "qapi/clone-visitor.h"
>> -#include "test-qapi-types.h"
>
> Overactive sed pattern? This is a different header. While the tests
> still pass after deleting this include, removal of the test-qapi-types.h
> line here and in other tests/ files should be a separate patch, or else
> the commit message updated to mention it.
Intentional. I'll amend the commit message.
- Re: [Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions, (continued)
- [Qemu-devel] [PATCH 06/18] Typedef the subtypes of QObject in qemu/typedefs.h, too, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 18/18] Move include qemu/option.h from qemu-common.h to actual users, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 03/18] Include qapi/error.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 16/18] Drop superfluous includes of qapi/qmp/dispatch.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 15/18] Include qapi/qmp/qnull.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 14/18] Include qapi/qmp/qnum.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 04/18] Drop superfluous includes of qapi/qmp/qerror.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where needed, Markus Armbruster, 2018/01/30