[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others |
Date: |
Wed, 31 Jan 2018 16:40:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 31.01.2018 15:48, Markus Armbruster wrote:
> System headers should be included with <...>, our own headers with
> "...". Offenders tracked down with an ugly, brittle and probably
> buggy Perl script. Previous iteration was commit a9c94277f0.
>
> Put the cleaned up system header includes first, except for the ones
> the next commit will delete.
That's a little bit of code churn ... why not delete them here
immediately, or simply ignore these headers here and just delete them in
the next patch?
> While there, separate #include from file comment with a blank line,
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
[...]
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 0570f597ec..9968974fbe 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -13,8 +13,8 @@
> */
>
>
While you're at it, remove one of the two blank lines?
> -#include "inttypes.h"
> -#include "stdio.h"
> +#include <inttypes.h>
> +#include <stdio.h>
> #include "cpu_features_def.h"
Above remarks are just nits, anyway patch looks fine, so:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v2 00/19] Clean up includes to reduce compile time, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 10/19] Include qapi/qmp/qobject.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 16/19] Include qapi/qmp/qnull.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 03/19] Drop superfluous includes of qapi-types.h and test-qapi-types.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 02/19] Clean up includes, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 07/19] Typedef the subtypes of QObject in qemu/typedefs.h, too, Markus Armbruster, 2018/01/31