[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: check dev parameter when updating msi rout
From: |
Radim Krčmář |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: check dev parameter when updating msi route |
Date: |
Fri, 2 Feb 2018 20:35:59 +0100 |
This should primarily go to the qemu devel list. I've Cc'd it, but
reposting would be safer, thanks.
2018-02-02 10:21+0530, P J P:
> From: Prasad J Pandit <address@hidden>
>
> When updating message signalled interrupt(MSI) route in routine
> kvm_irqchip_update_msi_route, device parameter could be null.
> Add check to avoid null dereference.
>
> Reported-by: Guoxiang Niu <address@hidden>
> Signed-off-by: Prasad J Pandit <address@hidden>
> ---
> accel/kvm/kvm-all.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index f290f487a5..cb7613d282 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -1167,7 +1167,7 @@ int kvm_irqchip_add_msi_route(KVMState *s, int vector,
> PCIDevice *dev)
> kroute.u.msi.address_lo = (uint32_t)msg.address;
> kroute.u.msi.address_hi = msg.address >> 32;
> kroute.u.msi.data = le32_to_cpu(msg.data);
> - if (pci_available && kvm_msi_devid_required()) {
> + if (pci_available && dev && kvm_msi_devid_required()) {
> kroute.flags = KVM_MSI_VALID_DEVID;
> kroute.u.msi.devid = pci_requester_id(dev);
> }
> @@ -1205,7 +1205,7 @@ int kvm_irqchip_update_msi_route(KVMState *s, int virq,
> MSIMessage msg,
> kroute.u.msi.address_lo = (uint32_t)msg.address;
> kroute.u.msi.address_hi = msg.address >> 32;
> kroute.u.msi.data = le32_to_cpu(msg.data);
> - if (pci_available && kvm_msi_devid_required()) {
> + if (pci_available && dev && kvm_msi_devid_required()) {
> kroute.flags = KVM_MSI_VALID_DEVID;
> kroute.u.msi.devid = pci_requester_id(dev);
> }
> --
> 2.14.3
>
- Re: [Qemu-devel] [PATCH] kvm: check dev parameter when updating msi route,
Radim Krčmář <=