[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exp
From: |
Marc-Andre Lureau |
Subject: |
Re: [Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exprs |
Date: |
Mon, 5 Feb 2018 14:45:05 +0100 |
On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <address@hidden> wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi/common.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
> index 6c6962a364..78e960d07c 100644
> --- a/scripts/qapi/common.py
> +++ b/scripts/qapi/common.py
> @@ -1457,13 +1457,13 @@ class QAPISchema(object):
> def __init__(self, fname):
> try:
> parser = QAPISchemaParser(open(fname, 'r'))
> - self.exprs = check_exprs(parser.exprs)
> + exprs = check_exprs(parser.exprs)
> self.docs = parser.docs
> self._entity_dict = {}
> self._predefining = True
> self._def_predefineds()
> self._predefining = False
> - self._def_exprs()
> + self._def_exprs(exprs)
> self.check()
> except QAPIError as err:
> print >>sys.stderr, err
> @@ -1648,8 +1648,8 @@ class QAPISchema(object):
> name, info, doc, 'arg', self._make_members(data, info))
> self._def_entity(QAPISchemaEvent(name, info, doc, data, boxed))
>
> - def _def_exprs(self):
> - for expr_elem in self.exprs:
> + def _def_exprs(self, exprs):
> + for expr_elem in exprs:
> expr = expr_elem['expr']
> info = expr_elem['info']
> doc = expr_elem.get('doc')
> --
> 2.13.6
>
- [Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h, (continued)
- [Qemu-devel] [PATCH RFC 20/21] Include less of qapi-types.h, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 16/21] qapi/types qapi/visit: Make visitors use QAPIGen more, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 05/21] qapi: Turn generators into modules, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 10/21] qapi/common: Eliminate QAPISchema.exprs, Markus Armbruster, 2018/02/02
- [Qemu-devel] [PATCH RFC 17/21] qapi/types qapi/visit: Generate built-in stuff into separate files, Markus Armbruster, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code, Daniel P . Berrangé, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code, no-reply, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code, no-reply, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code, no-reply, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code, no-reply, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 00/21] Modularize generated QAPI code, no-reply, 2018/02/02