[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL |
Date: |
Mon, 5 Feb 2018 16:18:23 +0100 |
The generic bdrv_dirname() implementation would be able to generate some
form of directory name for many NBD nodes, but it would be always wrong.
Therefore, we have to explicitly make it an error (until NBD has some
form of specification for export paths, if it ever will).
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/nbd.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/block/nbd.c b/block/nbd.c
index 94220f6d14..dcea7ffaef 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -574,6 +574,16 @@ static int nbd_get_info(BlockDriverState *bs,
BlockDriverInfo *bdi)
return 0;
}
+static char *nbd_dirname(BlockDriverState *bs, Error **errp)
+{
+ /* The generic bdrv_dirname() implementation is able to work out some
+ * directory name for NBD nodes, but that would be wrong. So far there is
no
+ * specification for how "export paths" would work, so NBD does not have
+ * directory names. */
+ error_setg(errp, "Cannot generate a base directory for NBD nodes");
+ return NULL;
+}
+
static BlockDriver bdrv_nbd = {
.format_name = "nbd",
.protocol_name = "nbd",
@@ -592,6 +602,7 @@ static BlockDriver bdrv_nbd = {
.bdrv_attach_aio_context = nbd_attach_aio_context,
.bdrv_refresh_filename = nbd_refresh_filename,
.bdrv_get_info = nbd_get_info,
+ .bdrv_dirname = nbd_dirname,
};
static BlockDriver bdrv_nbd_tcp = {
@@ -612,6 +623,7 @@ static BlockDriver bdrv_nbd_tcp = {
.bdrv_attach_aio_context = nbd_attach_aio_context,
.bdrv_refresh_filename = nbd_refresh_filename,
.bdrv_get_info = nbd_get_info,
+ .bdrv_dirname = nbd_dirname,
};
static BlockDriver bdrv_nbd_unix = {
@@ -632,6 +644,7 @@ static BlockDriver bdrv_nbd_unix = {
.bdrv_attach_aio_context = nbd_attach_aio_context,
.bdrv_refresh_filename = nbd_refresh_filename,
.bdrv_get_info = nbd_get_info,
+ .bdrv_dirname = nbd_dirname,
};
static void bdrv_nbd_init(void)
--
2.14.3
- [Qemu-devel] [PATCH v8 06/26] block: Make path_combine() return the path, (continued)
- [Qemu-devel] [PATCH v8 06/26] block: Make path_combine() return the path, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 07/26] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 08/26] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 09/26] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 11/26] block: Add bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL,
Max Reitz <=
- [Qemu-devel] [PATCH v8 16/26] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 19/26] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 17/26] iotests: Add quorum case to test 110, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Max Reitz, 2018/02/05