[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iotests: 205: support only raw format
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] iotests: 205: support only raw format |
Date: |
Mon, 5 Feb 2018 09:40:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 02/05/2018 06:50 AM, Vladimir Sementsov-Ogievskiy wrote:
> The test is about qmp interface to NBD server, so there no reasons
> to run it for various disk formats. Also it actually do not support
> luks format, so, disable all format except raw.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> tests/qemu-iotests/205 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
> index 10388920dc..a78ff37104 100644
> --- a/tests/qemu-iotests/205
> +++ b/tests/qemu-iotests/205
> @@ -153,4 +153,4 @@ class TestNbdServerRemove(iotests.QMPTestCase):
>
>
> if __name__ == '__main__':
> - iotests.main()
> + iotests.main(supported_fmts=['raw'])
Isn't that stricter than necessary? The test works with qcow2; it was
just luks that was special (because we weren't passing in proper
secrets). At any rate, I'm adding Dan in case he has a quick idea of
what it would take to get luks working, rather than just disabling it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature