[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v6 15/20] replay: check return values of fwrite
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v6 15/20] replay: check return values of fwrite |
Date: |
Wed, 07 Feb 2018 15:05:17 +0300 |
User-agent: |
StGit/0.17.1-dirty |
This patch adds error reporting when fwrite cannot completely
save the buffer to the file.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
--
v3: also check putc() return value
---
replay/replay-internal.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index 139b9fa..fd88b5b 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -24,12 +24,23 @@
static QemuMutex lock;
/* File for replay writing */
+static bool write_error;
FILE *replay_file;
+static void replay_write_error(void)
+{
+ if (!write_error) {
+ error_report("replay write error");
+ write_error = true;
+ }
+}
+
void replay_put_byte(uint8_t byte)
{
if (replay_file) {
- putc(byte, replay_file);
+ if (putc(byte, replay_file) == EOF) {
+ replay_write_error();
+ }
}
}
@@ -62,7 +73,9 @@ void replay_put_array(const uint8_t *buf, size_t size)
{
if (replay_file) {
replay_put_dword(size);
- fwrite(buf, 1, size, replay_file);
+ if (fwrite(buf, 1, size, replay_file) != size) {
+ replay_write_error();
+ }
}
}
- [Qemu-devel] [RFC PATCH v6 05/20] replay: fix processing async events, (continued)
- [Qemu-devel] [RFC PATCH v6 05/20] replay: fix processing async events, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 06/20] replay: fixed replay_enable_events, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 07/20] replay: fix save/load vm for non-empty queue, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 08/20] replay: added replay log format description, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 09/20] replay: save prior value of the host clock, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 10/20] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 11/20] replay/replay-internal.c: track holding of replay_lock, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 12/20] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 13/20] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 14/20] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 15/20] replay: check return values of fwrite,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v6 16/20] replay: avoid recursive call of checkpoints, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 18/20] replay: don't process async events when warping the clock, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 19/20] replay: save vmstate of the asynchronous events, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 17/20] scripts/replay-dump.py: replay log dumper, Pavel Dovgalyuk, 2018/02/07
- [Qemu-devel] [RFC PATCH v6 20/20] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/02/07
- Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions, Ciro Santilli, 2018/02/07