[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: Check the L1 table parameters from all i
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: Check the L1 table parameters from all internal snapshots |
|
Date: |
Fri, 09 Feb 2018 16:11:28 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 09 Feb 2018 04:03:31 PM CET, Kevin Wolf wrote:
> How about we move the check to bdrv_open() as proposed, but make it
> conditional so that it's skipped with BDRV_O_CHECK and then add a way
> to fix the situation with qemu-img check -r?
That was one of the alternatives that I was considering, but you can't
really fix a broken L1 table pointer, can you?
What you can probably do is allow deleting the snapshot, but 'qemu-img
snapshot' doesn't use BDRV_O_CHECK. We'd have to change that, look for a
new flag or think of some other alternative.
Or, perhaps more easily, make 'qemu-img check' delete all corrupted
snapshots.
Berto