[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 05/12] spapr: set vsmt to MAX(8, smp_threads)

From: David Gibson
Subject: [Qemu-devel] [PULL 05/12] spapr: set vsmt to MAX(8, smp_threads)
Date: Mon, 12 Feb 2018 14:40:47 +1100

From: Laurent Vivier <address@hidden>

We ignore silently the value of smp_threads when we set
the default VSMT value, and if smp_threads is greater than VSMT
kernel is going into trouble later.

Fixes: 8904e5a750
("spapr: Adjust default VSMT value for better migration compatibility")

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
 hw/ppc/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 96515036e6..9f29434819 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2310,7 +2310,7 @@ static void spapr_set_vsmt_mode(sPAPRMachineState *spapr, 
Error **errp)
          * the value that we'd get with KVM on POWER8, the
          * overwhelmingly common case in production systems.
-        spapr->vsmt = 8;
+        spapr->vsmt = MAX(8, smp_threads);
     /* KVM: If necessary, set the SMT mode: */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]