Re: [Qemu-devel] [PATCH v2 18/29] qapi: Rename generated qmp-marshal.c to qmp-commands.c

[Eric Blake]

On 02/11/2018 03:35 AM, Markus Armbruster wrote:
> All generated .c are named like their .h, except for qmp-marshal.c and
> qmp-commands.h.  To add to the confusion, tests-qmp-commands.c falsely
> matches generated test-qmp-commands.h.
>
> Get rid of this unnecessary complication.

Yay for saner naming.

> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   .gitignore                                     |  3 +--
>   Makefile                                       |  6 +++---
>   Makefile.objs                                  |  2 +-
>   docs/devel/qapi-code-gen.txt                   |  6 +++---
>   qga/Makefile.objs                              |  2 +-
>   scripts/qapi/commands.py                       |  2 +-
>   tests/.gitignore                               |  5 ++---
>   tests/Makefile.include                         | 10 +++++-----
>   tests/{test-qmp-commands.c => test-qmp-cmds.c} |  0
>   9 files changed, 17 insertions(+), 19 deletions(-)
>   rename tests/{test-qmp-commands.c => test-qmp-cmds.c} (100%)

> diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-cmds.c
> similarity index 100%
> rename from tests/test-qmp-commands.c
> rename to tests/test-qmp-cmds.c

Noticed while renaming this file - it's non-trivial in length, but bears 
no copyright or license clause.  Perhaps we should add that (but can be 
separate patch).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org