[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 28/30] ivshmem: use the BYTE-based definitions
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 28/30] ivshmem: use the BYTE-based definitions |
Date: |
Thu, 15 Feb 2018 16:40:21 +0100 |
On Thu, Feb 15, 2018 at 5:28 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
> It ease code review, unit is explicit.
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> hw/misc/ivshmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 16f03701b7..9b3ad96471 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -1302,7 +1302,7 @@ static void ivshmem_realize(PCIDevice *dev, Error
> **errp)
> }
>
> if (s->sizearg == NULL) {
> - s->legacy_size = 4 << 20; /* 4 MB default */
> + s->legacy_size = 4 * M_BYTE; /* 4 MB default */
> } else {
> int ret;
> uint64_t size;
> --
> 2.16.1
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 23/30] hw/net: use the BYTE-based definitions, (continued)
- [Qemu-devel] [PATCH 23/30] hw/net: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 24/30] hw/ipack: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 25/30] hw/scsi: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 22/30] hw/display: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 26/30] hw/smbios: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 27/30] vfio/pci: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 28/30] ivshmem: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 29/30] tpm: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14
- [Qemu-devel] [PATCH 30/30] xen: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/02/14