qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package


From: Sergei Trofimovich
Subject: Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package
Date: Thu, 15 Feb 2018 18:21:53 +0000

On Thu, 15 Feb 2018 14:35:39 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:

>  #else
> +#include <capstone/capstone.h>

I think it's incorrect. 'pkg-config' already reports 'capstone/' path:
    $ pkg-config --cflags capstone
    -I/usr/include/capstone

    $ ls /usr/include/capstone/capstone.h
    /usr/include/capstone/capstone.h

Thus I would guess
    #include <capstone.h>
is still correct for system include path as well (contradicts the example).

qemu just needs to use 'pkg-config' to discover the include path and
libs. Maybe new capstone release has different pkgconfig setup?

-- 

  Sergei



reply via email to

[Prev in Thread] Current Thread [Next in Thread]