qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv5 2/5] qmp: add query-cpus-fast


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCHv5 2/5] qmp: add query-cpus-fast
Date: Mon, 19 Feb 2018 10:54:29 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/16/2018 10:08 AM, Viktor Mihajlovski wrote:
From: Luiz Capitulino <address@hidden>

The query-cpus command has an extremely serious side effect:
it always interrupts all running vCPUs so that they can run
ioctl calls. This can cause a huge performance degradation for
some workloads. And most of the information retrieved by the
ioctl calls are not even used by query-cpus.

This commit introduces a replacement for query-cpus called
query-cpus-fast, which has the following features:

  o Never interrupt vCPUs threads. query-cpus-fast only returns
    vCPU information maintained by QEMU itself, which should be
    sufficient for most management software needs

  o Drop "halted" field as it can not be retrieved in a fast
    way on most architectures

  o Drop irrelevant fields such as "current", "pc" and "arch"

  o Rename some fields for better clarification & proper naming
    standard

Signed-off-by: Luiz Capitulino <address@hidden>
Signed-off-by: Viktor Mihajlovski <address@hidden>
---
  cpus.c           | 38 ++++++++++++++++++++++++++++++
  qapi-schema.json | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 108 insertions(+)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]