[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage |
Date: |
Tue, 20 Feb 2018 22:54:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 20/02/2018 18:04, Peter Lieven wrote:
> Hi,
>
> I remember we discussed a long time ago to limit the stack usage of all
> functions that are executed in a coroutine
> context to a very low value to be able to safely limit the coroutine
> stack size as well.
IIRC the only issue was that hw/ide/atapi.c has mutual recursion between
ide_atapi_cmd_reply_end -> ide_transfer_start -> ahci_start_transfer ->
ide_atapi_cmd_reply_end.
But perhaps it's not an issue, somebody needs to audit the code.
> I checked through all functions in block/, migration/ and nbd/ and there
> are only very few larger or unbound stack
> allocations that can easily be fixed.
Yeah, the really large allocations are very few and mostly have to do
with networking (https://wiki.qemu.org/BiteSizedTasks#Large_frames).
Unfortunately the link to the original list has died together with the
gmane archives.
Paolo
- [Qemu-devel] Limiting coroutine stack usage, Peter Lieven, 2018/02/20
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage,
Paolo Bonzini <=
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Kevin Wolf, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Peter Lieven, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Kevin Wolf, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Daniel P . Berrangé, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Peter Lieven, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Daniel P . Berrangé, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Peter Lieven, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Daniel P . Berrangé, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Peter Lieven, 2018/02/22
- Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage, Daniel P . Berrangé, 2018/02/22