[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/7] net: Make net_client_init() static
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PATCH v3 4/7] net: Make net_client_init() static |
Date: |
Wed, 21 Feb 2018 11:18:33 +0100 |
The function is only used within net.c, so there's no need that
this is a global function.
While we're at it, also remove the unused prototype compute_mcast_idx()
(the function has been removed in commit d9caeb09b107e91122d10ba4a08a).
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
include/net/net.h | 2 --
net/net.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/net/net.h b/include/net/net.h
index bdd4d9f..cd1708c 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -204,7 +204,6 @@ extern const char *host_net_devices[];
extern const char *legacy_tftp_prefix;
extern const char *legacy_bootp_filename;
-int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp);
int net_client_parse(QemuOptsList *opts_list, const char *str);
int net_init_clients(Error **errp);
void net_check_clients(void);
@@ -228,7 +227,6 @@ void qdev_set_nic_properties(DeviceState *dev, NICInfo *nd);
#define POLYNOMIAL_LE 0xedb88320
uint32_t net_crc32(const uint8_t *p, int len);
uint32_t net_crc32_le(const uint8_t *p, int len);
-unsigned compute_mcast_idx(const uint8_t *ep);
#define vmstate_offset_macaddr(_state, _field) \
vmstate_offset_array(_state, _field.a, uint8_t, \
diff --git a/net/net.c b/net/net.c
index cf07e15..dd80f1b 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1119,7 +1119,7 @@ static void show_netdevs(void)
}
}
-int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)
+static int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp)
{
void *object = NULL;
Error *err = NULL;
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/7] Improvements and clean-ups related to -net, Thomas Huth, 2018/02/21
- [Qemu-devel] [PATCH v3 1/7] net: Move error reporting from net_init_client/netdev to the calling site, Thomas Huth, 2018/02/21
- [Qemu-devel] [PATCH v3 2/7] net: List available netdevs with "-netdev help", Thomas Huth, 2018/02/21
- [Qemu-devel] [PATCH v3 6/7] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands, Thomas Huth, 2018/02/21
- [Qemu-devel] [PATCH v3 5/7] net: Remove the deprecated way of dumping network packets, Thomas Huth, 2018/02/21
- [Qemu-devel] [PATCH v3 3/7] net: Only show vhost-user in the help text if CONFIG_POSIX is defined, Thomas Huth, 2018/02/21
- [Qemu-devel] [PATCH v3 4/7] net: Make net_client_init() static,
Thomas Huth <=
- [Qemu-devel] [PATCH v3 7/7] net: Add a new convenience option "--nic" to configure default/on-board NICs, Thomas Huth, 2018/02/21
- Re: [Qemu-devel] [PATCH v3 0/7] Improvements and clean-ups related to -net, Mark Cave-Ayland, 2018/02/21
- Re: [Qemu-devel] [PATCH v3 0/7] Improvements and clean-ups related to -net, Jason Wang, 2018/02/27