[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/36] block: x-blockdev-create QMP command
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/36] block: x-blockdev-create QMP command |
Date: |
Thu, 22 Feb 2018 23:50:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-21 14:53, Kevin Wolf wrote:
> This adds a synchronous x-blockdev-create QMP command that can create
> qcow2 images on a given node name.
>
> We don't want to block while creating an image, so this is not the final
> interface in all aspects, but BlockdevCreateOptionsQcow2 and
> .bdrv_co_create() are what they actually might look like in the end. In
> any case, this should be good enough to test whether we interpret
> BlockdevCreateOptions as we should.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qapi/block-core.json | 12 ++++++++
> include/block/block_int.h | 2 ++
> block/create.c | 76
> +++++++++++++++++++++++++++++++++++++++++++++++
> block/qcow2.c | 3 +-
> block/Makefile.objs | 2 +-
> 5 files changed, 93 insertions(+), 2 deletions(-)
> create mode 100644 block/create.c
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 10/36] test-qemu-opts: Test qemu_opts_to_qdict_filtered(), (continued)
- [Qemu-devel] [PATCH v2 11/36] qdict: Introduce qdict_rename_keys(), Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 13/36] block: Make bdrv_is_whitelisted() public, Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 12/36] qcow2: Use visitor for options in qcow2_create(), Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 14/36] block: x-blockdev-create QMP command, Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 15/36] file-posix: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 17/36] gluster: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 20/36] rbd: Remove non-schema options from runtime_opts, Kevin Wolf, 2018/02/21
- [Qemu-devel] [PATCH v2 18/36] rbd: Fix use after free in qemu_rbd_set_keypairs() error path, Kevin Wolf, 2018/02/21