[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create op
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create option |
Date: |
Fri, 23 Feb 2018 00:43:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 2018-02-21 14:53, Kevin Wolf wrote:
> The "redundacy" option for Sheepdog image creation is currently a string
> that can encode one or two integers depending on its format, which at
> the same time implicitly selects a mode.
>
> This patch turns it into a QAPI union and converts the string into such
> a QAPI object before interpreting the values.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qapi/block-core.json | 45 +++++++++++++++++++++++++
> block/sheepdog.c | 94
> +++++++++++++++++++++++++++++++++++++---------------
> 2 files changed, 112 insertions(+), 27 deletions(-)
Ooooh, thanks!
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 21/36] rbd: Pass BlockdevOptionsRbd to qemu_rbd_connect(), (continued)
[Qemu-devel] [PATCH v2 25/36] nfs: Use QAPI options in nfs_client_open(), Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 22/36] rbd: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 26/36] nfs: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 27/36] sheepdog: QAPIfy "redundacy" create option, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 28/36] sheepdog: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 30/36] ssh: QAPIfy host-key-check option, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 29/36] ssh: Use QAPI BlockdevOptionsSsh object, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 32/36] ssh: Support .bdrv_co_create, Kevin Wolf, 2018/02/21
[Qemu-devel] [PATCH v2 33/36] file-posix: Fix no-op bdrv_truncate() with falloc preallocation, Kevin Wolf, 2018/02/21