[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 3/4] tests/migration: Add migration-test head
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH V5 3/4] tests/migration: Add migration-test header file |
Date: |
Mon, 26 Feb 2018 10:05:59 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Fri, Feb 23, 2018 at 03:58:57PM -0600, Wei Huang wrote:
> This patch moves the settings related migration-test from the
> migration-test.c file to a seperate header file. It also renames the
> x86-a-b-bootblock.s file extension from .s to .S, allowing gcc
> pre-processor to include the C-style header file correctly.
>
> Signed-off-by: Wei Huang <address@hidden>
> ---
> tests/migration-test.c | 28
> +++++++++++-----------
> tests/migration/Makefile | 4 ++--
> tests/migration/migration-test.h | 18 ++++++++++++++
> .../{x86-a-b-bootblock.s => x86-a-b-bootblock.S} | 7 +++---
> tests/migration/x86-a-b-bootblock.h | 2 +-
> 5 files changed, 39 insertions(+), 20 deletions(-)
> create mode 100644 tests/migration/migration-test.h
> rename tests/migration/{x86-a-b-bootblock.s => x86-a-b-bootblock.S} (94%)
>
I gave this my r-b last review. Do I have to review it again?
[Qemu-devel] [PATCH V5 1/4] rules: Move cross compilation auto detection functions to rules.mak, Wei Huang, 2018/02/23