Re: [Qemu-devel] [PATCH V5 4/4] tests: Add migration test for aarch64

[Andrew Jones]

On Mon, Feb 26, 2018 at 10:30:31AM +0100, Andrew Jones wrote:
> On Fri, Feb 23, 2018 at 03:58:58PM -0600, Wei Huang wrote:
> > +        /* aarch64 virt machine physical memory starts at 0x40000000, which
> > +         * is also the kernel loader base address. It should be fine to
> 
> It's not the kernel base address.
> 
> > +         * allocate & modify the test memory 1MB away.
> 
> It's only 512K away - which is still probably fine, but you
> said he found data once when reading every 4K after 1M, so
> maybe not.
>

BTW, I'd just drop this comment altogether, rather than fix it.
Or fix it, but put it in the header. The point of the header
is to avoid these addresses spreading around too much. Putting
them in comments doesn't help.

drew