[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename
|
From: |
Julia Suvorova |
|
Subject: |
Re: [Qemu-devel] [PATCH] use g_path_get_basename instead of basename |
|
Date: |
Thu, 1 Mar 2018 14:25:22 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01.03.2018 13:59, Cornelia Huck wrote:
> On Thu, 1 Mar 2018 10:47:42 +0100
> Marc-André Lureau <address@hidden> wrote:
>
>> Hi
>>
>> On Thu, Mar 1, 2018 at 8:08 AM, Julia Suvorova via Qemu-devel
>> <address@hidden> wrote:
>>> basename(3) and dirname(3) modify their argument and may return
>>> pointers to statically allocated memory which may be overwritten by
>>> subsequent calls.
>>> g_path_get_basename and g_path_get_dirname have no such issues, and
>>> therefore more preferable.
>>>
>>> Signed-off-by: Julia Suvorova <address@hidden>
>>
>> What about adding a warning for basename()/dirname() usage in
>> scripts/checkpatch.pl ?
>
> +1 to that.
>
Ok. I'll prepare a separate patch for that.
Thanks for the review.
>>
>> Reviewed-by: Marc-André Lureau <address@hidden>
>
> Reviewed-by: Cornelia Huck <address@hidden>
>