[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/13] intel-iommu: Accept 64-bit writes to FEADDR
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 03/13] intel-iommu: Accept 64-bit writes to FEADDR |
Date: |
Thu, 1 Mar 2018 18:45:55 +0200 |
From: Jan Kiszka <address@hidden>
Xen is doing this [1] and currently triggers an abort.
[1]
http://xenbits.xenproject.org/gitweb/?p=xen.git;a=blob;f=xen/drivers/passthrough/vtd/iommu.c;h=daaed0abbdd06b6ba3d948ea103aadf02651e83c;hb=refs/heads/master#l1108
Reported-by: Luis Lloret <address@hidden>
Signed-off-by: Jan Kiszka <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/i386/intel_iommu.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 2e841cd..fb31de9 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2129,8 +2129,15 @@ static void vtd_mem_write(void *opaque, hwaddr addr,
/* Fault Event Address Register, 32-bit */
case DMAR_FEADDR_REG:
- assert(size == 4);
- vtd_set_long(s, addr, val);
+ if (size == 4) {
+ vtd_set_long(s, addr, val);
+ } else {
+ /*
+ * While the register is 32-bit only, some guests (Xen...) write to
+ * it with 64-bit.
+ */
+ vtd_set_quad(s, addr, val);
+ }
break;
/* Fault Event Upper Address Register, 32-bit */
--
MST
- [Qemu-devel] [PULL 00/13] virtio, vhost, pci, pc: features, fixes and cleanups, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 03/13] intel-iommu: Accept 64-bit writes to FEADDR,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 01/13] vhost-user: fix memory leak, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 02/13] virtio-pci: trivial fixes in error message, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 04/13] docs: document virtio-balloon stats, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 09/13] docs/vmcoreinfo: detail unsupported host format behaviour, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 05/13] docs: pcie: Spell out machine type needs for PCIe features, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 06/13] vhost: fix memslot limit check, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 11/13] cryptodev: add vhost support, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 10/13] cryptodev: add vhost-user as a new cryptodev backend, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 07/13] vhost: avoid to start/stop virtqueue which is not ready, Michael S. Tsirkin, 2018/03/01
- [Qemu-devel] [PULL 08/13] vhost: fix incorrect check in vhost_verify_ring_mappings, Michael S. Tsirkin, 2018/03/01