Re: [Qemu-devel] [PATCH v2 12/15] chardev: introduce chr_machine_done hook

[Paolo Bonzini]

On 01/03/2018 09:44, Peter Xu wrote:
> Introduce ChardevClass.chr_machine_done() hook so that chardevs can run
> customized procedures after machine init.
> 
> There was an existing mux user already that did similar thing but used a
> raw machine done notifier.  Generalize it into a framework, and let the
> mux chardevs provide such a class-specific hook to achieve the same
> thing.  Then we can move the mux related code to the char-mux.c file.
> 
> This notifier framework will be further leverged by other type of
> chardevs soon.
> 
> Signed-off-by: Peter Xu <address@hidden>
> ---
>  chardev/char-mux.c     | 29 +++++++++++++++++++++++++++++
>  chardev/char.c         | 43 +++++++++++++++++--------------------------
>  include/chardev/char.h |  2 ++
>  3 files changed, 48 insertions(+), 26 deletions(-)

Modulo the note on muxes_realized (see patch 15/15),

Reviewed-by: Paolo Bonzini <address@hidden>