[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/9] chardev: fix leak in tcp_chr_telnet_init_io()
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH 2/9] chardev: fix leak in tcp_chr_telnet_init_io() |
Date: |
Mon, 5 Mar 2018 14:50:33 +0800 |
Need to free TCPChardevTelnetInit when session established.
Since at it, switch to use G_SOURCE_* macros.
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
chardev/char-socket.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 113feaf948..205ee377a4 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -591,19 +591,23 @@ static gboolean tcp_chr_telnet_init_io(QIOChannel *ioc,
ret = 0;
} else {
tcp_chr_disconnect(init->chr);
- return FALSE;
+ goto end;
}
}
init->buflen -= ret;
if (init->buflen == 0) {
tcp_chr_connect(init->chr);
- return FALSE;
+ goto end;
}
memmove(init->buf, init->buf + ret, init->buflen);
- return TRUE;
+ return G_SOURCE_CONTINUE;
+
+end:
+ g_free(init);
+ return G_SOURCE_REMOVE;
}
static void tcp_chr_telnet_init(Chardev *chr)
--
2.14.3
- [Qemu-devel] [PATCH 0/9] chardev: qio related non-default context support, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 1/9] vl: export machine_init_done, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 2/9] chardev: fix leak in tcp_chr_telnet_init_io(),
Peter Xu <=
- [Qemu-devel] [PATCH 3/9] chardev: update net listener gcontext, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 4/9] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 6/9] chardev: use chardev's gcontext for async connect, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 5/9] chardev: introduce chr_machine_done hook, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 7/9] chardev: tcp: postpone async connection setup, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 8/9] chardev: tcp: let TLS run on chardev context, Peter Xu, 2018/03/05